Skip to content

Fix non-constant format string error on go 1.26 - #3392

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
dsimansk:pr/fix-format-string
Oct 9, 2026
Merged

Fix non-constant format string error on go 1.26#3392
knative-prow[bot] merged 1 commit into
knative:mainfrom
dsimansk:pr/fix-format-string

Conversation

@dsimansk

@dsimansk dsimansk commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Fix non-constant format string error on go 1.26

Bumping go directive in go.mod to force error fix verification through unit tests. The 1.26's go vet is has tighter recognition of string formatters not being present.

testing/duck/testbindable.go:153:63: non-constant format string in call to (knative.dev/pkg/apis.ConditionManager).MarkFalse

Appeared here: #3391

Release Note

Fix non-constant format string error on go 1.26

/cc @gauron99 @kahirokunn

@knative-prow knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2026
@dsimansk

dsimansk commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

There's couple more occasions of same use across our repos: #3387

@codecov

codecov Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.88%. Comparing base (d2a153a) to head (3ad1cca).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3392      +/-   ##
==========================================
+ Coverage   74.85%   74.88%   +0.02%     
==========================================
  Files         189      189              
  Lines        8349     8349              
==========================================
+ Hits         6250     6252       +2     
+ Misses       1854     1853       -1     
+ Partials      245      244       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Sep 17, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@knative knative deleted a comment from knative-prow Bot Sep 21, 2026
@gauron99

gauron99 commented Sep 21, 2026

Copy link
Copy Markdown

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2026
@dsimansk

dsimansk commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Until downstream Serving repo is resolved.

/hold

@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2026
@kahirokunn

kahirokunn commented Sep 21, 2026

Copy link
Copy Markdown
Member

/lgtm

@aliok
aliok requested a lite review from Copilot October 6, 2026 20:13
@aliok

aliok commented Oct 6, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

@knative-prow

knative-prow Bot commented Oct 6, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI reviewed Oct 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reviewed changes address the Go 1.26 diagnostic without unresolved issues.

Review effort: Lite
Findings: None

What changed in this PR

Fixes Go 1.26 format-string validation errors while preserving condition messages.

Changes:

  • Uses a constant %s format for dynamic messages.
  • Updates the Go module directive to 1.26.0.
File Description
testing/​duck/​testbindable.go Fixes the non-constant format string call.
go.mod Sets the required Go version to 1.26.0.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dsimansk

dsimansk commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

/unhold

@knative-prow knative-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2026
@knative-prow
knative-prow Bot merged commit 8c9ee30 into knative:main Oct 9, 2026
114 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@gauron99 gauron99 Awaiting requested review from gauron99
@kahirokunn kahirokunn Awaiting requested review from kahirokunn

Assignees

@aliok aliok

@kahirokunn kahirokunn

@gauron99 gauron99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dsimansk @gauron99 @kahirokunn @aliok